Repository navigation
Update Attribute to include "Type" and "Defalut value" as children - #5439
Merged
Merged
Conversation
Eric Harvey (eharvey328)
marked this pull request as ready for review
August 6, 2026 14:18
Eric Harvey (eharvey328)
changed the title
Axel Hernández Ferrera (axelhzf)
previously approved these changes
Aug 12, 2026
Contributor
Author
|
Axel Hernández Ferrera (@axelhzf) I got the inline-code styling to work The challenge is the source does not output these as inline-code blocks so we have to add them somewhere. `[Value](href) | [Another](href)` // links becomes a stringWe need to parse each token individually: [`Value`](href) | [`Another`](href)That works for the type, but default value can have complex values with spaces and chars: Default value: \<default case>Since this represents a value, it is safe to assume there won't be any type def links. So we can wrap the whole thing in a code block |
Axel Hernández Ferrera (axelhzf)
previously approved these changes
Aug 13, 2026
Axel Hernández Ferrera (axelhzf)
approved these changes
Aug 19, 2026
Aida Albarrán Blanco (Alienah)
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes
attributeTypeHintandattributeTypeHintHrefprops onAttributemdx component.method: QiskitType | dict[Qiskititem] | None)did not implement an ignore list for links to python standard types because these links are already display in other places in the docs. If we want we can handle in a follow up.
Packages migrated: